Enable "useDefineForClassFields" in tsc --init #39362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
approved these changes
Jul 1, 2020
sandersn
requested changes
Sep 2, 2020
|
The design meeting ended up with a laundry list of options we aren't sure whether to recommend in
So I think we need to discuss this again in the design meeting. @DanielRosenwasser |
typescript-bot
added
the
For Uncommitted Bug
|
After discussing this in the design meeting, this is on hold until the target ES version is the one that has Define semantics by default. |
|
I'm going to close this PR to keep things tidy since it's not clear when Define will be part of the standard. Also, since esnext now implies useDefineForClassFields, setting the target will imply the correct value, whether it's esnext or es20xx. |
|
The TypeScript team hasn't accepted the linked issue #39311. If you can get it accepted, this PR will have a better chance of being reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39311
This changes adds
"useDefineForClassFields": trueto the defaulttsconfig.jsongenerated bytsc --init. The impact is that new projects will adopt standard browser semantics. Existing projects are not affected.Please forgive the whitespace noise in the the test baselines. The new comma after
"forceConsistentCasingInFileNames"results in a one-character column of whitespace rippling upwards.Backlogmilestone (required)masterbranchgulp runtestslocally